This repository has been archived by the owner on Apr 29, 2023. It is now read-only.
test_utility.TestGetMatchingFiles: Fix for paths containing dots. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the leading path contains a '.', the file extension test in TestGetMatchingFiles would fail. Fix it by matching either start-of-line or a directory separator before looking for dot and end-of-line.
pabigot
approved these changes
Sep 18, 2016
pabigot
added a commit
that referenced
this pull request
Sep 18, 2016
Signed-off-by: Peter A. Bigot <pab@pabigot.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm packaging PyXB for GNU Guix which sets TMPDIR as
/tmp/guix-build-python-pyxb-1.2.4-0. This caused https://github.com/pabigot/pyxb/blob/master/tests/utils/test-utility.py#L694 to fail because__NoExt_rematches the directory that precedes the temporary files.You can reproduce it by e.g.
mkdir /tmp/path.with.dots; TMPDIR=/tmp/path.with.dots python setup.py test.The following commit should fix it. Escaping
%sis not strictly necessary on Unix, but does not seem to hurt, and I think it's required on platforms with more awkward directory separators. Changing*to+is optional :)Thanks!