Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highchart license issue #623

Closed
Nek- opened this issue Oct 30, 2017 · 3 comments
Closed

Highchart license issue #623

Nek- opened this issue Oct 30, 2017 · 3 comments

Comments

@Nek-
Copy link

Nek- commented Oct 30, 2017

Hello

Highcharts have a commercial license. However, you include it by default in the packages.json as a dependency. This is a serious conflict of license. Many developers may think they can use your library to make charts as it.

Please consider to remove that dependency or add a huge warning on the readme. Please also be careful because I'm not a lawyer but I'm not sure you're in right to put an MIT license on top of the license of Highcharts.

@Nek- Nek- changed the title License issue Highchart license issue Oct 30, 2017
@dhodgin
Copy link

dhodgin commented Oct 30, 2017

By including highcharts in the package as well it forces everyone to use highcharts only. You cannot make use of highstock or highmaps when using ES6 import it seems.

your also forced to use highchart 5 when highcharts 6 is out. I want to use highstock 6 and cannot using imports and webpack it seems.

Filing a separate issue for that though #624

@pablojim
Copy link
Owner

pablojim commented Nov 3, 2017

@Nek @dhodgin I think this is an issue. On balance it's best to remove the dependency on highcharts and flag this clearly in the docs.

PRs gladly accepted or else wait for me to get around to it.

@pablojim
Copy link
Owner

pablojim commented Dec 2, 2017

Resolved in 1.2.0 release

@pablojim pablojim closed this as completed Dec 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants