-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for $onChanges, added new binding to disable change detection #622
Conversation
@ngehlert Looks good so far if you could add something to the docs and add a jsfiddle example to the examples directory then I'd be happy to merge. Thanks! |
@pablojim i updated the readme. not quite sure how i should add a jsfiddle since it is not merged yet. |
@ngehlert Thanks. I've merged that. If you get a chance to make a jsfiddle and link to it from the readme that would be great. |
@pablojim ok awesome. one last question regarding the jsfiddle. do i just create/update an example there and hit save and add the link? i saw that you have a separate directory with jsfiddle files. how does this work, where do they come from? |
* upstream/master: added support for $onChanges, added new binding to disable change detection (pablojim#622)
So http://jsfiddle.net/gh/get/jquery/3.1.1/pablojim/highcharts-ng/tree/master/jsfiddles/basic/ This gets the html, js and "details" from: It means we can manage the source of example jsfiddles in github. This is prefereable to just creating one in jsfiddle itself. Easiest to just copy one of the existing examples and modify it. |
ok, didn't know that. thanks. this is actually a nice feature 😄 going to add the examples then |
@pablojim sorry to bother you again. do you have any plans for the release date? is there any other issue / pr you want to have in there as well and need some help with? |
like discussed in #621 I added support for $onChanges and the new disableChangeDetection binding.
a little side not: due the nature of $onChanges being called before $onInit but the DOM not rendered at this point of time I still kept support for $onInit. So everything stays the same, I just added the $onChanges method to support later changes. A flag if the $onInit was already called is needed for this.
Should I also update the documentation?
Let me know if you have any questions.