Add JWT support #187
Merged
Add JWT support #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miremond : we talked about it, I did it ;-) |
| * @author Jerome Leleu | ||
| * @since 1.8.0 | ||
| */ | ||
| public class JwtGenerator<U extends UserProfile> { |
There was a problem hiding this comment.
What is the purpose of this class? is it only for tests? If no, maybe we should parameterized the signature or encryption methods. Otherwise we can move it to the test directory
There was a problem hiding this comment.
Good question! This class is meant to generate a JWT from an existing user profile. The typical use case is an application where the user can login with Facebook for example and then generates a token to access web services. This was inspired by this discussion: https://groups.google.com/forum/?fromgroups#!topic/pac4j-users/kJMw8vvZBJY
|
Congrats @leleuj ! I give you a kudo! |
papegaaij
pushed a commit
to topicusonderwijs/pac4j
that referenced
this pull request
Jun 26, 2019
Add JWT support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generation + authentication