Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and a small refactor for non-strict positional #381

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Test and a small refactor for non-strict positional #381

merged 2 commits into from
Jul 29, 2024

Conversation

pacak
Copy link
Owner

@pacak pacak commented Jul 29, 2024

  • copy is good when cheap
  • exhaustive pattern match is good
  • and we should be careful about suggesting completions - -- doesn't fit there

it should not suggest adding double dash
While at it - make Positional into Copy and make match exhaustive
@pacak pacak merged commit d10410f into master Jul 29, 2024
3 checks passed
@pacak pacak deleted the pos-test branch July 29, 2024 22:11
@pacak pacak mentioned this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant