-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new round tripper package #296
Conversation
Lgtm |
default: | ||
return nil, err | ||
} | ||
return nil, err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep mapping the ErrRetryFailed
as code may depends on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The used package does not provide a dedicated error on exceeded retry. Instead the normal request error / status is returned. Currently I do not see an easy way to achieve this.
Pipeline red? |
Closing in favour of #326 |
The old roundtripper package did not preserve the request body on retries. This has been solve by exchanging to another package providing that handling.