feat: Display uncropped media on account media pages #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously media on the "Media" tab was displayed scaled and cropped to a square aspect ratio, effectively forcing the user to tap every image to see it. Now, display the images scaled but not cropped, layed out with `StaggeredGridLayoutManager`. This shows each image in full (still scaled) providing a better experience when scrolling down. Scrolling up can occasionally introduce gaps in the grid as images are re-placed as viewholders are reused. When this happens images animate to a better position when scrolling stops.
Previous code injected `ApplicationContext`, which is not themed, and caused a crash if the "update" dialog was shown. Fix by passing the necesssary context in explicitly when the check is performed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously media on the "Media" tab was displayed scaled and cropped to a square aspect ratio, effectively forcing the user to tap every image to see it.
Now, display the images scaled but not cropped, layed out with
StaggeredGridLayoutManager. This shows each image in full (still scaled) providing a better experience when scrolling down.Scrolling up can occasionally introduce gaps in the grid as images are re-placed as viewholders are reused. When this happens images animate to a better position when scrolling stops.