fix: Don't focus search query when returning to the results list #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code always focused the search query. This meant that if the user: 1. Searched for something 2. Opened a result (post, hashtag, account) 3. Navigated back to the search results then because the query was focused the soft-keyboard would open, obscuring the list of results. The user had to press "Back" again to dismiss the keyboard. New code only focuses the search query view if it is empty. This allows the user to come back to the list of results and immediately open a new result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code always focused the search query. This meant that if the user:
then because the query was focused the soft-keyboard would open, obscuring the list of results. The user had to press "Back" again to dismiss the keyboard.
New code only focuses the search query view if it is empty. This allows the user to come back to the list of results and immediately open a new result.