Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flags to create genomebam file with kallisto bus #184

Merged
merged 2 commits into from Jan 14, 2023

Conversation

ricomnl
Copy link

@ricomnl ricomnl commented Jan 4, 2023

kallisto bus has the following optional options:

--genomebam               Project pseudoalignments to genome sorted BAM file
-g, --gtf                     GTF file for transcriptome information
                              (required for --genomebam)
-c, --chromosomes             Tab separated file with chromosome names and lengths
                              (optional for --genomebam, but recommended)

This PR adds parameters to kb count so that one can use the --genomebam flag as well as a gtf file and optionally a chromosomes file to output a .bam file. A test is added to make sure the functionality works as intended.

@ricomnl
Copy link
Author

ricomnl commented Jan 4, 2023

@sbooeshaghi @Lioscro this would be a useful addition IMO because BAM files are required for downstream tasks like genetic demultiplexing. Right now, one would have to use cellranger to get bam files. In addition, the PR would solve this previous issue #147

@Yenaled
Copy link
Collaborator

Yenaled commented Jan 13, 2023

@ricomnl I am the person currently making major upgrades to and maintaining kallisto. Thanks for the pull request. I have several updates I need to make first but I will try to merge this pull request when I can. Don't worry -- it's on my radar.

@Lioscro
Copy link
Collaborator

Lioscro commented Jan 14, 2023

As long as the commands printed from --dry-run looks reasonable, the changes lgtm.

@Yenaled
Copy link
Collaborator

Yenaled commented Jan 14, 2023

@Lioscro all looks good to me; feel free to merge

@Lioscro Lioscro changed the base branch from master to devel January 14, 2023 17:01
@Lioscro Lioscro merged commit 7aabc4b into pachterlab:devel Jan 14, 2023
@Lioscro Lioscro mentioned this pull request Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants