Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scatter plot hyphen bug #89

Closed
PeterVenhuizen opened this issue Dec 12, 2016 · 2 comments
Closed

Scatter plot hyphen bug #89

PeterVenhuizen opened this issue Dec 12, 2016 · 2 comments

Comments

@PeterVenhuizen
Copy link

Some of my samples have hyphens in their names, which works fine, except for generating the scatter plots, see the attached image. The easy solution would of course be to change my sample names, but it would be nice if it would work!

sleuth_hyphen_bug

warrenmcg added a commit to warrenmcg/sleuth that referenced this issue Mar 16, 2017
…trary string can be used as a sample name; proposed solution for pachterlab#89
@warrenmcg
Copy link
Collaborator

Hi @PeterVenhuizen,

Hyphens are a tricky thing in R because they're interpreted as minus signs. So, your combination of hyphens and underscores leads to a syntax error (you can see the exact same error if you try typing in 7-1-1_A at the R interactive prompt without quotes). I made a proposed change to plot_scatter that should alleviate this problem. For the time being, you can either (A) wait for the change to be incorporated into the next release, (B) incorporate the change into your own code, or (C) change your names to not have hyphens.

Hope this helps!
Warren

@pimentel
Copy link
Collaborator

pimentel commented Jun 5, 2017

Fixed in the latest version by @warrenmcg!

Thanks again!

@pimentel pimentel closed this as completed Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants