Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use grave accents ` to allow any sample name for plot_scatter #96

Closed
wants to merge 2 commits into from

Conversation

warrenmcg
Copy link
Collaborator

Hi,

In plot_scatter, aes_string from ggplot2 is used to take the log of the normalized counts for the scatter plot using the sample name as an expression. However, sample names that would cause a syntax error (e.g. using hyphens, which are interpreted as minus signs) cause an error unless the grave accent ' ` ' is used (this is the source of the error in #89).

I'm not sure if there is another case where this proposed code would break when the original wouldn't (maybe check to make sure the sample names exist in the sample_to_covariates table?), but here is the proposed solution.

Best,
Warren

@warrenmcg
Copy link
Collaborator Author

My new pull request incorporates this code, so I'm closing this pull request in favor of the new one.

@warrenmcg warrenmcg closed this Apr 22, 2017
@pimentel pimentel mentioned this pull request May 29, 2017
@warrenmcg warrenmcg deleted the issue89 branch June 3, 2017 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant