Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for partial port forwarding, rather than all-or-none #3577

Merged
merged 9 commits into from
Mar 12, 2019
Merged

Support for partial port forwarding, rather than all-or-none #3577

merged 9 commits into from
Mar 12, 2019

Conversation

ysimonson
Copy link
Contributor

@ysimonson ysimonson commented Mar 11, 2019 •
edited
Loading

Fixes #3572

I also went ahead and changed the port forwarder to use logrus instead of stderr for output created by k8s itself, which fixes #3578

@ysimonson ysimonson requested a review from jdoliner March 11, 2019 20:48
jdoliner
jdoliner approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@jdoliner jdoliner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ysimonson ysimonson merged commit f94845e into master Mar 12, 2019
@ysimonson ysimonson deleted the partial-port-forwarding branch March 12, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdoliner jdoliner jdoliner approved these changes

Assignees

@jdoliner jdoliner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

k8s port forwarding endpoint prints to stdout/stderr Partial port forwarding
2 participants
@ysimonson @jdoliner