Fix dash compatibility check #5063
Conversation
|
Your website preview is ready! Hooray! 🎉 Built with commit 3f3bef6 |
| @@ -1319,7 +1319,7 @@ func getDefaultOrLatestDashImage(dashImage string, dryRun bool) string { | |||
| return dashImage | |||
| } | |||
| dashImage = defaultDashImage | |||
| compatibleDashVersionsURL := fmt.Sprintf("https://raw.githubusercontent.com/pachyderm/pachyderm/master/etc/compatibility/%v", version) | |||
There was a problem hiding this comment.
I don't think we typically generate dash compatibility files for custom releases, so the first version arg should be the version without VersionAdditional if (and only if) VersionAdditional looks like a git commit hash.
There was a problem hiding this comment.
Technically we are creating the compatibility file so we should commit it. But the instructions don't call for it, so we have not been doing it for a long time.
I'll make this change.
|
|
||
| ``` | ||
| > git commit -a -m"Regenerate golden deployment manifests for $(pachctl version --client-only)" | ||
| > git push origin master | ||
| ``` | ||
|
|
||
| 10) Update the |
There was a problem hiding this comment.
If we're reconsidering the order of these steps - I'd propose we move the changelog up above the make point-release step. Obviously we can't edit the release notes at that point, but it's rather nice to have the CHANGELOG.md contain the relevant data under the release's git tag.
doc/release_instructions.md
Outdated
| - `src/client/version/client.go` version values | ||
| - for a major release increment the MajorVersion and set the MinorVersion and MicroVersion to 0 --> eg. 2.0.0 | ||
| - for a minor release leave the MajorVersion unchanged, increment the MinorVersion, and set the MicroVersion to 0 --> eg. 1.10.0 | ||
| - for a patch release leave the MajorVersion and MinorVersion unchanged and increment the MicorVersion --> eg. 1.9.8 |
There was a problem hiding this comment.
typo here
| - for a patch release leave the MajorVersion and MinorVersion unchanged and increment the MicorVersion --> eg. 1.9.8 | |
| - for a patch release, leave the MajorVersion and MinorVersion unchanged and increment the MicroVersion --> eg. 1.9.8 |
doc/release_instructions.md
Outdated
| 3) Update client version. Commit these changes locally. You will push to GitHub in the next step. | ||
| - [Required for Major, Minor, and Patch releases] | ||
| - `src/client/version/client.go` version values | ||
| - for a major release increment the MajorVersion and set the MinorVersion and MicroVersion to 0 --> eg. 2.0.0 |
There was a problem hiding this comment.
punctuation nit
| - for a major release increment the MajorVersion and set the MinorVersion and MicroVersion to 0 --> eg. 2.0.0 | |
| - for a major release, increment the MajorVersion and set the MinorVersion and MicroVersion to 0 --> eg. 2.0.0 |
doc/release_instructions.md
Outdated
| - [Required for Major, Minor, and Patch releases] | ||
| - `src/client/version/client.go` version values | ||
| - for a major release increment the MajorVersion and set the MinorVersion and MicroVersion to 0 --> eg. 2.0.0 | ||
| - for a minor release leave the MajorVersion unchanged, increment the MinorVersion, and set the MicroVersion to 0 --> eg. 1.10.0 |
There was a problem hiding this comment.
punctuation nit
| - for a minor release leave the MajorVersion unchanged, increment the MinorVersion, and set the MicroVersion to 0 --> eg. 1.10.0 | |
| - for a minor release, leave the MajorVersion unchanged, increment the MinorVersion, and set the MicroVersion to 0 --> eg. 1.10.0 |
… a release. Also fix handling of custom releases in checking for dash compatibility
|
@msteffen I made changes to the release process. Most of it is moving all the commits we do as part of the release process before the git tag is created. You may want to take a quick pass at it as well. |
Fix dash compatibility check
No description provided.