Prevent launch script from denying Docker v1.6.0 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may be noted that this won't scale with more versions.
|
it any better way to compare the version? in case docker update to 1.7.0, we need to update this again |
|
We could use something like cloudflare/semver_bash, or we can parse it manually. I can try out parsing later today. |
|
Thanks for the pull! I think the easiest way to compare version numbers that won't break on new versions is with Also would you mind make this a pull in to pachyderm:next. Merging in to master automatically ships the code so as a general rule we merge in to next and then in to master when we want to ship. (This should be in the Readme but it's not. [0] http://stackoverflow.com/questions/16989598/bash-comparing-version-numbers#answer-24067243 |
Merged
chainlink
pushed a commit
that referenced
this pull request
Jul 21, 2022
* feat(e2e): run cypress tests against real server * feat(e2e): add mount test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be noted that this won't scale with more versions.
Fixes: #52