Fix Docker version check #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the Docker version check by parsing it with sed. It enforces: - major version = 1 - minor version >= 5 When the Docker major is bumped (= backwards incompatible change), we stay on the safe side and force users to upgrade for support.
|
👍 Nice one. |
|
Thanks! |
chainlink
pushed a commit
that referenced
this pull request
Jun 30, 2021
Signed-off-by: echohack <git@echohack.app>
chainlink
added a commit
that referenced
this pull request
Jul 21, 2022
Create preview environment on PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the Docker version check by parsing it with sed.
It enforces:
When the Docker major is bumped (= backwards incompatible change), we
stay on the safe side and force users to upgrade for support.
This PR is a resubmit/redo of #53.
Fixes: #52
/cc @jdoliner @waitingkuo