[CORE-824] Disallow configuring logs in text format #8112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.3.x #8112 +/- ##
==========================================
- Coverage 22.28% 22.25% -0.03%
==========================================
Files 415 415
Lines 112171 112171
==========================================
- Hits 24995 24962 -33
- Misses 82900 82922 +22
- Partials 4276 4287 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jrockway
requested changes
Aug 23, 2022
| @@ -10,6 +10,10 @@ pachctl config set active-context local | |||
| pachctl port-forward | |||
| {{- end -}} | |||
|
|
|||
| {{- if eq .Values.pachd.logFormat "text" }} | |||
| WARNING: setting log format to text is not supported. Defaulting to json | |||
| {{- end -}} | |||
There was a problem hiding this comment.
I think I'd warn that it's going away in 2.4 and not remove it in 2.3. Seems odd for a patch release to make a change this large, even if "text" isn't that great.
There was a problem hiding this comment.
Ahh okay, can do!
FahadBSyed
force-pushed
the
CORE-842-2.3.X
branch
from
db292f4
to
5198237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.