Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE-824] Disallow configuring logs in text format #8112

Merged
merged 1 commit into from
Aug 29, 2022
Merged

[CORE-824] Disallow configuring logs in text format #8112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions etc/helm/pachyderm/templates/NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ pachctl config set active-context local
pachctl port-forward
{{- end -}}

{{- if eq .Values.pachd.logFormat "text" }}
WARNING: setting log format to text is deprecated in 2.3 and will be removed in 2.4.
{{- end -}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd warn that it's going away in 2.4 and not remove it in 2.3. Seems odd for a patch release to make a change this large, even if "text" isn't that great.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh okay, can do!


{{ if and (.Values.oidc.mockIDP) (.Values.pachd.enterpriseLicenseKey) (.Values.pachd.activateAuth) }}
WARNING: Your cluster is configured with a default login of admin:password
{{- end -}}
Expand Down