Fix Spout and Service pipeline restart issue #8308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also account for Service pipelines
Codecov Report
@@ Coverage Diff @@
## master #8308 +/- ##
==========================================
- Coverage 38.61% 38.55% -0.06%
==========================================
Files 429 429
Lines 118795 118796 +1
==========================================
- Hits 45867 45803 -64
- Misses 63780 63821 +41
- Partials 9148 9172 +24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
robert-uhl
approved these changes
Oct 21, 2022
albscui
pushed a commit
that referenced
this pull request
Oct 21, 2022
* [CORE-1177] Fix Spout pipeline unable to restart after being stopped * add a test for Spout restart * also account for Service pipelines * increase sleep duration to deflake test Co-authored-by: defiori <46789010+defiori@users.noreply.github.com>
albscui
pushed a commit
that referenced
this pull request
Oct 24, 2022
* Fix Spout and Service pipeline restart issue (#8308) * [CORE-1177] Fix Spout pipeline unable to restart after being stopped * add a test for Spout restart * also account for Service pipelines * increase sleep duration to deflake test Co-authored-by: defiori <46789010+defiori@users.noreply.github.com> * revert project-aware client calls Co-authored-by: defiori <46789010+defiori@users.noreply.github.com>
robert-uhl
pushed a commit
that referenced
this pull request
Oct 26, 2022
* [CORE-1177] Fix Spout pipeline unable to restart after being stopped * add a test for Spout restart * also account for Service pipelines * increase sleep duration to deflake test Co-authored-by: defiori <46789010+defiori@users.noreply.github.com>
robert-uhl
pushed a commit
that referenced
this pull request
Oct 27, 2022
* [CORE-1177] Fix Spout pipeline unable to restart after being stopped * add a test for Spout restart * also account for Service pipelines * increase sleep duration to deflake test Co-authored-by: defiori <46789010+defiori@users.noreply.github.com>
albscui
pushed a commit
that referenced
this pull request
Oct 28, 2022
* [CORE-1177] Fix Spout pipeline unable to restart after being stopped * add a test for Spout restart * also account for Service pipelines * increase sleep duration to deflake test Co-authored-by: defiori <46789010+defiori@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #8303
Thanks to @defiori for discovering the bug and pushing a fix! ❤️