Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Fix for Spout pipelines not able to restart #8310

Merged
merged 2 commits into from Oct 24, 2022

Conversation

albscui
Copy link
Contributor

@albscui albscui commented Oct 21, 2022

No description provided.

Albert and others added 2 commits October 21, 2022 16:05
* [CORE-1177] Fix Spout pipeline unable to restart after being stopped

* add a test for Spout restart

* also account for Service pipelines

* increase sleep duration to deflake test

Co-authored-by: defiori <46789010+defiori@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #8310 (71ee9e0) into 2.3.x (278239f) will decrease coverage by 18.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            2.3.x   #8310       +/-   ##
==========================================
- Coverage   22.33%   3.47%   -18.87%     
==========================================
  Files         415     201      -214     
  Lines      112266   74159    -38107     
==========================================
- Hits        25076    2577    -22499     
+ Misses      82930   71219    -11711     
+ Partials     4260     363     -3897     
Impacted Files Coverage Δ
src/server/auth/db.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/watch/op.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/miscutil/log.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/miscutil/math.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/grpcutil/error.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/randutil/unique.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/testutil/naming.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/storage/fileset/metadata_store.go 0.00% <0.00%> (-100.00%) ⬇️
src/internal/storage/track/tracker.go 3.70% <0.00%> (-96.30%) ⬇️
src/internal/task/etcd_queue.go 0.00% <0.00%> (-93.55%) ⬇️
... and 362 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@robert-uhl robert-uhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@albscui albscui merged commit c5f9fd8 into 2.3.x Oct 24, 2022
@albscui albscui deleted the albert/2.3.x/CORE-1177-spout-restart branch October 24, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants