Add filepath to /metadata response #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rod-glover
force-pushed
the
i184-metadata-filepath
branch
from
7aac381
to
f8aed47
Compare
jameshiebert
requested changes
Oct 29, 2020
| .filter(DataFileVariableDSGTimeSeries.netcdf_variable_name == var) | ||
| ) | ||
| for Table in joins: | ||
| q = q.join(Table) |
There was a problem hiding this comment.
That's a nice way to do it.
| @@ -1,6 +1,7 @@ | |||
| import os | |||
| from os.path import basename | |||
|
|
|||
| from sqlalchemy.orm.exc import NoResultFound, MultipleResultsFound | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22 . Also fixes python-ci test environment.
This PR changes the
/metadataendpoint in the following ways:minandmaxincludewith the following valid values, specified as a comma-separated list:unitsfilepathrequestan optional query parameter with the following meanings:request=GetMinMax: default responserequest=GetMinMaxWithUnits: includeunitsin responseAn example request to this revised API is
/metadata.json?include=filepath,units.This change supersedes ("deprecates" is too strong a word) the previous API definition, by effectively replacing the
requestparameter with theincludeparameter. However, the oldrequest=style still functions as it did to ensure backward compatibility.This PR also adds the infrastructure for building a Docker image containing an appropriate test environment for this package. It has been exercised and works as advertised. It is a minor variation of the infrastructure established for the same purpose in PyCDS.