Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checkout step from Docker build action #114

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Remove checkout step from Docker build action #114

merged 1 commit into from
Aug 8, 2022

Conversation

flavioheleno
Copy link
Member

Closes #113

@okiedork
Copy link
Contributor

okiedork commented Aug 8, 2022

I started a workflow run in this branch but it failed: https://github.com/package-health/php/actions/runs/2817949914

Looks like it couldn't find the docker dir.

@flavioheleno
Copy link
Member Author

Do we need to do anything prior to the build so that we don't need to rely on actions/checkout?

@okiedork
Copy link
Contributor

okiedork commented Aug 8, 2022 •
edited
Loading

@flavioheleno try removing the context input setting from the build step and trigger a new workflow run.

okiedork
okiedork approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@okiedork okiedork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@okiedork okiedork merged commit dc644e3 into develop Aug 8, 2022
@okiedork okiedork deleted the improv/build-docker-image branch August 8, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okiedork okiedork okiedork approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove checkout step from Docker build action
2 participants
@flavioheleno @okiedork