Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken tests on master. #12

Merged
merged 2 commits into from May 20, 2019
Merged

Fix broken tests on master. #12

merged 2 commits into from May 20, 2019

Conversation

petergardfjall
Copy link
Contributor

This commit fixes a few issues with the code related to:

  • parsing: some purl-type specific handling is required to deal with things such
    as case
  • string conversion: certain fields need to be percent-encoded

@petergardfjall petergardfjall mentioned this pull request May 20, 2019
Closed
@ashcrow
Copy link
Contributor

ashcrow commented May 20, 2019 

go get -u github.com/golang/lint/golint
package github.com/golang/lint/golint: code in directory /home/travis/gopath/src/github.com/golang/lint/golint expects import "golang.org/x/lint/golint"
make: *** [lint] Error 1
The command "make lint" exited with 2.

Unrelated failure.

@ashcrow ashcrow self-requested a review May 20, 2019 14:29
ashcrow
ashcrow approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashcrow
Copy link
Contributor

ashcrow commented May 20, 2019

Rebase is needed 🙏

@petergardfjall
Fix broken tests on master.
90cbfdf 
This commit fixes a few issues with the code related to:

- parsing: some purl-type specific handling is required to deal with things such
  as case
- string conversion: certain fields need to be percent-encoded
@petergardfjall
update travis go version: 1.9 -> 1.12
f9008a0
@petergardfjall
Copy link
Contributor Author

Rebased and updated Travis to use Go 1.12. golint still appears to fail in Travis, but the tests are green.

@ashcrow ashcrow merged commit 3550741 into package-url:master May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow ashcrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@petergardfjall @ashcrow