Marshmallow v3 support #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
TomasTomecek
approved these changes
Apr 6, 2020
|
exactly as @TomasTomecek if tests will pass than it is ok |
sakalosj
approved these changes
Apr 6, 2020
This comment has been minimized.
This comment has been minimized.
|
|
I'd drop the |
Pardon my ignorance, but where does one do that? |
|
Does it occur often? I've seen that maybe twice and see some value in that check. |
|
Build failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged together with packit/packit-service#538
If you want to test with marshmallow-3, you can use this rpm.
I was trying to inherit more of our classes (like
JobConfig) from the MM23Schema, but there's some advanced magic, which prevented me from doing that. Since this is a temporary code (until F31 is EOL) I can live with that, can you too?I'll address #744 and #782 separately.