Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support list of versions for sync-release #2408

Closed
6 tasks
Tracked by #2068
mfocko opened this issue Apr 25, 2024 · 0 comments · Fixed by packit/packit#2317
Closed
6 tasks
Tracked by #2068

Support list of versions for sync-release #2408

mfocko opened this issue Apr 25, 2024 · 0 comments · Fixed by packit/packit#2317
Assignees
@lbarcziova
Labels
area/fedora Related to Fedora ecosystem area/rhel-ecosystem RHEL & CentOS stream complexity/single-task Regular task, should be done within days. kind/feature New feature or a request for enhancement.

Comments

@mfocko
Copy link
Member

mfocko commented Apr 25, 2024 •
edited

Summary

Pass around versions in a list (for New Hotness we can have just one version in the list, for Anitya version update fail)

TODO

  • Decide whether it's better fit to handle multiple versions in the handlers on service-side only, or implement it directly in the Packit API as suggested in the following points
  • Adjust sync-release “API” call to be able to take list of versions instead of just one
    https://github.com/packit/packit/blob/d3cd78c0f90402f8b87d96ebd967cbf3d448148b/packit/api.py#L823
    • For now it makes sense to expect (can be checked with a simple assert) that only one version has been given, and take the first one
    • Follow ups to handle multiple versions will be opened later
  • Adjust the CLI calls to the API to pass the list
  • Adjust the packit-service calls to the API to pass the list

Notes

Affects mainly pull-from-upstream

Part of #2068
@mfocko mfocko changed the title Support list of versions for pull-from-upstream Support list of versions for sync-release Apr 25, 2024
@mfocko mfocko mentioned this issue Apr 25, 2024
Open
9 tasks
@nforro nforro added kind/feature New feature or a request for enhancement. area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. area/rhel-ecosystem RHEL & CentOS stream labels Apr 25, 2024
@lbarcziova lbarcziova self-assigned this May 15, 2024
lbarcziova added a commit to lbarcziova/packit that referenced this issue May 20, 2024
@lbarcziova
Allow passing versions as list for sync_release
65631e8 
Fixes packit/packit-service#2408
Related to packit/packit-service#2068
lbarcziova added a commit to lbarcziova/packit that referenced this issue May 20, 2024
@lbarcziova
Allow passing versions as list for sync_release
079def6 
Fixes packit/packit-service#2408
Related to packit/packit-service#2068
lbarcziova added a commit to lbarcziova/packit that referenced this issue May 20, 2024
@lbarcziova
Allow passing versions as list for sync_release
b7ecdfc 
Fixes packit/packit-service#2408
Related to packit/packit-service#2068
@lbarcziova lbarcziova mentioned this issue May 20, 2024
Merged
lbarcziova added a commit to lbarcziova/packit that referenced this issue May 20, 2024
@lbarcziova
Allow passing versions as list for sync_release
feb6e83 
Fixes packit/packit-service#2408
Related to packit/packit-service#2068
lbarcziova added a commit to lbarcziova/packit that referenced this issue May 27, 2024
@lbarcziova
Allow passing versions as list for sync_release
3206fd6 
Fixes packit/packit-service#2408
lbarcziova added a commit to lbarcziova/packit that referenced this issue May 29, 2024
@lbarcziova
Allow passing versions as list for sync_release
415f98c 
Fixes packit/packit-service#2408
softwarefactory-project-zuul bot added a commit to packit/packit that referenced this issue May 29, 2024
@softwarefactory-project-zuul
Allow passing versions as list for sync_release (#2317)
c8c0314 
Allow passing versions as list for sync_release

Fixes packit/packit-service#2408
Related to packit/packit-service#2068
Allow passing it as a new parameter to be explicit. With this, the CLI/service doesn't need to be touched for now and in followup implementation (next points in packit/packit-service#2068) the list will be passed only for AnityaVersionUpdateEvent.
RELEASE NOTES BEGIN
N/A
RELEASE NOTES END

Reviewed-by: Matej Focko
Reviewed-by: Laura Barcziová
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbarcziova lbarcziova

Labels
area/fedora Related to Fedora ecosystem area/rhel-ecosystem RHEL & CentOS stream complexity/single-task Regular task, should be done within days. kind/feature New feature or a request for enhancement.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow passing versions as list for sync_release lbarcziova/packit
3 participants
@mfocko @nforro @lbarcziova