Allow passing versions as list for sync_release #2317
Conversation
|
Build failed. ✔️ pre-commit SUCCESS in 2m 12s |
lbarcziova
force-pushed
the
allow-passing-version-list
branch
from
b7ecdfc
to
feb6e83
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 02s |
| @@ -771,14 +771,12 @@ def check_version_distance( | |||
| and masked_proposed | |||
| and masked_current.group(0) != masked_proposed.group(0) | |||
| ): | |||
| raise ReleaseSkippedPackitException( | |||
There was a problem hiding this comment.
:classic: Pythonic… instead of having a predicate, yeet the error out /o
packit/api.py
Outdated
| version: Optional[str] = None, | ||
| tag: Optional[str] = None, | ||
| versions: Optional[list[str]] = None, |
There was a problem hiding this comment.
The initial idea I had, was to remove (or at least deprecate) the version and use just versions, since it doesn't really matter whether there is just one version in the list or multiple 🤔
Now that I'm thinking about it, we could even have version as a local variable, start by populating it (from nothing, the ifs you have expanded to check for versions), and then just use as we did before.
There was a problem hiding this comment.
I wanted to be rather explicit here whether there is one concrete version to propose or it should be determined in the method later (this cannot happen right in the beginning since we use the checked-out branch to get the current version in specfile for comparisons); so that way it seemed to me like less intrusive
also, in packit-service, we currently utilise the tag rather than version, see here, so the code for anitya will need to be still changed
but I am not strongly against, so I can rework it that way if you prefer that solution
lbarcziova
force-pushed
the
allow-passing-version-list
branch
from
feb6e83
to
3206fd6
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 4m 23s |
as I wrote in the comments above, in the service we are actually passing |
lbarcziova
force-pushed
the
allow-passing-version-list
branch
from
2071028
to
415f98c
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 3m 50s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 05s |
softwarefactory-project-zuul
bot
merged commit c8c0314
into
packit:main
Fixes packit/packit-service#2408
Related to packit/packit-service#2068
Allow passing it as a new parameter to be explicit. With this, the CLI/service doesn't need to be touched for now and in followup implementation (next points in packit/packit-service#2068) the list will be passed only for
AnityaVersionUpdateEvent.RELEASE NOTES BEGIN
N/A
RELEASE NOTES END