Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement denylisting #2046

Merged
merged 2 commits into from
May 17, 2023
Merged

Implement denylisting #2046

merged 2 commits into from
May 17, 2023

Conversation

lbarcziova
Copy link
Member

@lbarcziova lbarcziova commented May 10, 2023 •
edited
Loading

Fixes #1964

RELEASE NOTES BEGIN
We have implemented a denylisting mechanism allowing us to denylist namespaces/projects to prevent misuse of our service.
RELEASE NOTES END

@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/b3f99fcf4b224f299abe90f5c2ccc1e9

✔️ pre-commit SUCCESS in 2m 16s
✔️ packit-service-tests SUCCESS in 2m 35s
✔️ packit-service-tests-openshift SUCCESS in 14m 04s

@lbarcziova
Implement checking of denied project and actor
312ed89 
We already had the 'denied' value in allowlist, let's utilise it both
for checking the project and actor.
For project, check all parent namespaces for denied value.
Related to packit#1964
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5fb112c7439e493dbaa4d472e4cad854

✔️ pre-commit SUCCESS in 2m 12s
✔️ packit-service-tests SUCCESS in 2m 27s
✔️ packit-service-tests-openshift SUCCESS in 12m 16s

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label May 17, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c5c6a272b11c417dbf87dffbc6a806a8

✔️ pre-commit SUCCESS in 2m 09s
✔️ packit-service-tests SUCCESS in 2m 26s
✔️ packit-service-tests-openshift SUCCESS in 11m 55s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/05e8de16a04a4d6b84f68efc3bfa6242

✔️ pre-commit SUCCESS in 2m 08s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 01cbaf4 into packit:main May 17, 2023
@lbarcziova lbarcziova deleted the denylist branch May 17, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpopelka jpopelka jpopelka approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement blocklisting mechanism
2 participants
@lbarcziova @jpopelka