Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitLab can be now both upstream and downstream forge #2118

Closed
1 of 3 tasks
mfocko opened this issue Oct 8, 2023 · 0 comments · Fixed by #2120
Closed
1 of 3 tasks

GitLab can be now both upstream and downstream forge #2118

mfocko opened this issue Oct 8, 2023 · 0 comments · Fixed by #2120
Assignees
@mfocko
Labels
area/cli Impact on packit's command-line interface complexity/single-task Regular task, should be done within days. kind/bug Something isn't working.

Comments

@mfocko
Copy link
Member

mfocko commented Oct 8, 2023

What happened? What is the problem?

With the changes for the CentOS support I have introduced a bug that causes the upstream/downstream detection of the current working directory to deduce all repos as upstream ones (affects CLI). This bug is fixed by #2117, though it introduces another problem as gitlab.com can now be both upstream and downstream (CentOS ∨ RHEL).

TODO:

  • If forge is not strictly used for dist-git repositories, include the namespace in the deduction

What did you expect to happen?

Correctly deduced upstream/downstream.

Example URL(s)

No response

Steps to reproduce

No response

Workaround

  • There is an existing workaround that can be used until this issue is fixed.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@mfocko mfocko added kind/bug Something isn't working. area/cli Impact on packit's command-line interface complexity/single-task Regular task, should be done within days. labels Oct 8, 2023
@mfocko mfocko self-assigned this Oct 8, 2023
mfocko added a commit to mfocko/status that referenced this issue Oct 10, 2023
@mfocko
Add a notice about the GitLab.com disruption
da30f7f 
Related to packit/packit#2118

Signed-off-by: Matej Focko <mfocko@redhat.com>
@mfocko mfocko mentioned this issue Oct 10, 2023
Merged
mfocko added a commit to packit/status that referenced this issue Oct 10, 2023
@mfocko
Add a notice about the GitLab.com disruption (#108)
6a8a5e3 
Related to packit/packit#2118
mfocko added a commit to mfocko/packit that referenced this issue Oct 10, 2023
@mfocko
fix(cli): resolve upstream/downstream correctly
7884341 
Fixes packit#2118

Signed-off-by: Matej Focko <mfocko@redhat.com>
mfocko added a commit to mfocko/packit that referenced this issue Oct 10, 2023
@mfocko
fix(cli): resolve upstream/downstream correctly
ca57366 
Fixes packit#2118

Signed-off-by: Matej Focko <mfocko@redhat.com>
mfocko added a commit to mfocko/packit that referenced this issue Oct 10, 2023
@mfocko
fix(cli): resolve upstream/downstream correctly
a6a4cc2 
Fixes packit#2118

Signed-off-by: Matej Focko <mfocko@redhat.com>
@mfocko mfocko linked a pull request Oct 10, 2023 that will close this issue
Resolving the upstream/downstream dilemma on GitLab.com #2120
Merged
3 tasks
@mfocko mfocko mentioned this issue Oct 11, 2023
Merged
3 tasks
softwarefactory-project-zuul bot added a commit that referenced this issue Oct 11, 2023
@softwarefactory-project-zuul
Resolving the upstream/downstream dilemma on GitLab.com (#2120)
2e0ea06 
Resolving the upstream/downstream dilemma on GitLab.com

(or generally any git-forge that can share upstream/downstream)
TODO:

 Write new tests or update the old ones to cover new functionality.
 Update doc-strings where appropriate.
 Update or write new documentation in packit/packit.dev.



Fixes #2118
Fixes #2121
RELEASE NOTES BEGIN
We have fixed an issue that prevented you from running the jobs on the GitLab.com due to failing resolution of the upstream/downstream relationship for the cloned project.
RELEASE NOTES END

Reviewed-by: Matej Focko
Reviewed-by: Laura Barcziová
Reviewed-by: Maja Massarini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfocko mfocko

Labels
area/cli Impact on packit's command-line interface complexity/single-task Regular task, should be done within days. kind/bug Something isn't working.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolving the upstream/downstream dilemma on GitLab.com mfocko/packit
1 participant
@mfocko