Changelog refactor #1367
Merged
Changelog refactor #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
packit/utils/changelog_helper.py
Outdated
| release=release_to_update, changelog_entry=msg | ||
| ) | ||
|
|
||
| def prepare_upstream_locally(self, version: str, commit: str) -> None: |
There was a problem hiding this comment.
I think we should rename this method to something which would resemble what it actually does; update_spec?
There was a problem hiding this comment.
current name is the caller…
| self.dg.get_absolute_specfile_path(), | ||
| ) | ||
|
|
||
| def prepare_upstream_using_source_git(self) -> None: |
|
@mfocko a friendly reminder you have this one still opened :) |
mfocko
added
high-prio
has-release-notes
mfocko
force-pushed
the
propose-downstream-changelog
branch
from
dda6bd0
to
1c1302d
Compare
|
Build succeeded.
|
TomasTomecek
reviewed
Nov 1, 2021
| if not messages: | ||
| return None | ||
|
|
||
| return "\n".join(map(lambda line: line.rstrip(), messages)) |
There was a problem hiding this comment.
nicely done wrt .rstrip(), since the entries may contain important leading whitespace
| Returns: | ||
| Changelog entry or `None` if action is not present. | ||
| """ | ||
| messages = self.up.get_output_from_action(ActionName.changelog_entry) |
There was a problem hiding this comment.
I'm wondering if it makes sense to provide some env vars here to assist with the generation:
- spec file? (well, they know where it is and it's constant)
- project name, package name? dtto
- version name of the release in-progress - this one would make sense even though HEAD should be git-tagged, so also easy to find out
- git-log data - easy to find out
- previous release - we don't know that
- what else?
mfocko
force-pushed
the
propose-downstream-changelog
branch
from
1c1302d
to
c8a4504
Compare
|
Build succeeded.
|
TomasTomecek
approved these changes
Nov 10, 2021
Signed-off-by: Matej Focko <mfocko@redhat.com>
Signed-off-by: Matej Focko <mfocko@redhat.com>
Signed-off-by: Matej Focko <mfocko@redhat.com>
Signed-off-by: Matej Focko <mfocko@redhat.com>
Signed-off-by: Matej Focko <mfocko@redhat.com>
Signed-off-by: Matej Focko <mfocko@redhat.com>
mfocko
force-pushed
the
propose-downstream-changelog
branch
from
c8a4504
to
159c4c7
Compare
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Fixes #1299
Related to
Merge before/after
Packit supports
changelog-entryaction that is used when creating SRPM, the action is supposed to generate whole changelog entry (including-at the start of the lines) and has a priority over any other way we modify the changelog with.