Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple distgit external package config #1840

Closed
wants to merge 3 commits into from
Closed

Multiple distgit external package config #1840

wants to merge 3 commits into from

Conversation

majamassarini
Copy link
Member

DO NOT MERGE.

This is just a SPIKE PR to propose multiple solutions on how to refactor the packit_api object to support monorepos.

related to #1618
related to #1838

@majamassarini majamassarini mentioned this pull request Jan 25, 2023
Closed
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ pre-commit SUCCESS in 2m 31s
✔️ packit-tests-rpm SUCCESS in 14m 19s
✔️ packit-tests-pip-deps SUCCESS in 15m 02s
✔️ packit-tests-git-main SUCCESS in 15m 33s
✔️ packit-tests-pip-deps-sess-rec SUCCESS in 3m 26s
✔️ packit-tests-git-main-sess-rec SUCCESS in 4m 28s
❌ reverse-dep-packit-service-tests FAILURE in 3m 49s

@majamassarini majamassarini force-pushed the multiple_distgit_external_package_config branch from 82d21d9 to 1d50542 Compare January 26, 2023 12:01
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 2m 16s
✔️ packit-tests-rpm SUCCESS in 12m 54s
✔️ packit-tests-pip-deps SUCCESS in 14m 54s
✔️ packit-tests-git-main SUCCESS in 14m 10s
✔️ packit-tests-pip-deps-sess-rec SUCCESS in 4m 02s
✔️ packit-tests-git-main-sess-rec SUCCESS in 4m 03s
✔️ reverse-dep-packit-service-tests SUCCESS in 4m 29s

TomasTomecek
TomasTomecek reviewed Jan 31, 2023
View reviewed changes
packit/cli/builds/koji_build.py
kwargs["package_config"] = packages_config
func(*args, **kwargs)

return covered_func
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like an efficient solution here for the CLI though I wonder how we could apply it in packit-service too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR packit/packit-service#1873 my considerations about packit-service.

@majamassarini majamassarini mentioned this pull request Jan 31, 2023
Closed
@majamassarini majamassarini force-pushed the multiple_distgit_external_package_config branch from 1d50542 to 58dd60d Compare February 2, 2023 11:22
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 1m 56s
✔️ packit-tests-rpm SUCCESS in 13m 01s
✔️ packit-tests-pip-deps SUCCESS in 13m 29s
✔️ packit-tests-git-main SUCCESS in 14m 03s
✔️ packit-tests-pip-deps-sess-rec SUCCESS in 2m 25s
✔️ packit-tests-git-main-sess-rec SUCCESS in 2m 48s
✔️ reverse-dep-packit-service-tests SUCCESS in 3m 29s

@majamassarini
Copy link
Member Author

I close this PR, it was just an example for supporting the SPIKE on how to handle packit refactoring for monorepo.

Related research could be found here: https://github.com/packit/research/tree/main/monorepo-support/refactoring

This was referenced Feb 9, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasTomecek TomasTomecek TomasTomecek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@majamassarini @TomasTomecek