better wording when packit cannot parse YAML file #1861
Conversation
xsuchy
force-pushed
the
yamlerror
branch
2 times, most recently
from
414da0e
to
423cadb
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 01s |
|
Updated. |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 50s |
| msg = ( | ||
| " parser says\n" | ||
| + str(ex.problem_mark) | ||
| + "\n " | ||
| + str(ex.problem) # type: ignore | ||
| ) # type: ignore |
There was a problem hiding this comment.
msg = f" parser says\n{ex.problem_mark}\n {ex.problem}" # type: ignoreworks OK (pre-commit doesn't complain) for me, but I don't mind having it multi-line
Previously it prints:
2023-02-23 16:23:13.305 package_config.py ERROR Cannot load package config /tmp/fedora-upgrade/.packit.yaml.
2023-02-23 16:23:13.305 utils.py ERROR Cannot load package config: ScannerError('while scanning for the next token', None, "found character '\\t' that cannot start any token", <yaml.error.Mark object at 0x7f3310e2a190>).
Now it prints:
2023-02-23 17:25:59.950 package_config.py ERROR Cannot load package config /tmp/fedora-upgrade/.packit.yaml.
2023-02-23 17:25:59.950 package_config.py ERROR parser says
in "<unicode string>", line 12, column 1:
- fedora-stable
^
found character '\t' that cannot start any token while scanning for the next token
2023-02-23 17:25:59.950 utils.py ERROR Please correct data and retry.
Waive mypy errors about
packit/config/package_config.py:198: error: "YAMLError" has no attribute "context" [attr-defined]
packit/config/package_config.py:203: error: "YAMLError" has no attribute "problem" [attr-defined]
packit/config/package_config.py:205: error: "YAMLError" has no attribute "context" [attr-defined]
packit/config/package_config.py:209: error: "YAMLError" has no attribute "problem" [attr-defined]
as they exists when the error occure.
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 42s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 39s |
|
Well done Mirek! I already saw the first sentry issues about this and knew exactly what went wrong. |
Previously it printed:
Now it prints:
TODO:
packit/packit.dev.RELEASE NOTES BEGIN
Command
packit validate-confignow provides details about errors when it cannot parse the config file.RELEASE NOTES END