Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure %license is SPDX compatible #2026

Merged

Conversation

TomasTomecek
Copy link
Member

@TomasTomecek TomasTomecek commented Aug 4, 2023

$ askalono crawl LICENSE
LICENSE
License: MIT (original text)
Score: 1.000

https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

The changelog should propagate to dist-git as the SPDX migration
initiative tracks 'spdx' string in changelogs.

I'm at the SPDX hackfest right now and the guidance I got about the
LICENSE Copyright line was:

  1. it's meaningless and a waste of time to polish
  2. only the "copyright" word has a meaning
  3. the year is meaningless, hence I dropped it
  4. the team name & authors is relevant so I updated it to match 100%
    what we have in the source files

RELEASE NOTES BEGIN

Packit's license in RPM specfile is now confirmed to be SPDX compatible.

RELEASE NOTES END

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/22d8dcf27130420d8416ad0193207343

✔️ pre-commit SUCCESS in 1m 26s
✔️ packit-tests-rpm SUCCESS in 13m 05s
✔️ packit-tests-pip-deps SUCCESS in 13m 32s
✔️ packit-tests-git-main SUCCESS in 13m 18s
✔️ packit-tests-pip-deps-sess-rec SUCCESS in 2m 17s
✔️ packit-tests-git-main-sess-rec SUCCESS in 2m 36s
✔️ reverse-dep-packit-service-tests SUCCESS in 3m 31s

```
$ askalono crawl LICENSE
LICENSE
License: MIT (original text)
Score: 1.000
```

https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

The changelog should propagate to dist-git as the SPDX migration
initiative tracks 'spdx' string in changelogs.

I'm at the SPDX hackfest right now and the guidance I got about the
LICENSE Copyright line was:
1. it's meaningless and a waste of time to polish
2. only the "copyright" word has a meaning
3. the year is meaningless, hence I dropped it
4. the team name & authors is relevant so I updated it to match 100%
   what we have in the source files

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@TomasTomecek TomasTomecek added the mergeit When set, zuul wil gate and merge the PR. label Aug 4, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/27d4c527e4a041eba762f092f05bcc5d

✔️ pre-commit SUCCESS in 1m 32s
✔️ packit-tests-rpm SUCCESS in 12m 35s
✔️ packit-tests-pip-deps SUCCESS in 12m 56s
✔️ packit-tests-git-main SUCCESS in 13m 02s
✔️ packit-tests-pip-deps-sess-rec SUCCESS in 2m 08s
✔️ packit-tests-git-main-sess-rec SUCCESS in 2m 25s
✔️ reverse-dep-packit-service-tests SUCCESS in 3m 09s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/bef25e23bd2d4d4f83ce7676a4abf77a

✔️ pre-commit SUCCESS in 1m 30s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b15908b into packit:main Aug 4, 2023
17 of 19 checks passed
@TomasTomecek TomasTomecek deleted the update-license branch August 4, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants