Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't sync ACLs by default during release syncing #2214

Merged
merged 1 commit into from Jan 23, 2024
Merged

Don't sync ACLs by default during release syncing #2214

merged 1 commit into from Jan 23, 2024

Conversation

lbarcziova
Copy link
Member

@lbarcziova lbarcziova commented Jan 23, 2024 •
edited

This was mainly added for the service, so we will pass this argument from there and in CLI, by default not sync the ACLS. Fixes #2206
TODO:

  • packit-service PR to pass the sync_acls=True

RELEASE NOTES BEGIN

pull-from-upstream and propose-downstream commands now have the --sync-acls option that enables syncing the ACLs between dits-git repo and fork. The default behaviour was, however, changed to not sync the ACLs.

RELEASE NOTES END

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/65a2c6a9a3a743a09e5817f5095cc100

✔️ pre-commit SUCCESS in 7m 59s
❌ packit-tests-rpm FAILURE in 23m 51s
❌ packit-tests-pip-deps FAILURE in 23m 47s
❌ packit-tests-git-main FAILURE in 22m 21s
✔️ packit-tests-pip-deps-sess-rec SUCCESS in 3m 04s
✔️ packit-tests-git-main-sess-rec SUCCESS in 3m 17s
✔️ reverse-dep-packit-service-tests SUCCESS in 4m 02s

@lbarcziova
Copy link
Member Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/7327f4bdf8a0459ea3529f3fb7c55759

✔️ pre-commit SUCCESS in 1m 52s
❌ packit-tests-rpm FAILURE in 21m 55s
❌ packit-tests-pip-deps FAILURE in 21m 41s
❌ packit-tests-git-main FAILURE in 24m 07s
✔️ packit-tests-pip-deps-sess-rec SUCCESS in 2m 54s
✔️ packit-tests-git-main-sess-rec SUCCESS in 3m 16s
✔️ reverse-dep-packit-service-tests SUCCESS in 3m 50s

@lbarcziova
Don't sync ACLs by default during release syncing
33848cc 
This was mainly added for the service, so we will pass this argument
from there and in CLI, by default not sync the ACLS.
Fixes packit#2206
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/0931ef6ff5cd436c9540e2fe20b3b7ca

❌ pre-commit FAILURE in 3m 40s
✔️ packit-tests-rpm SUCCESS in 23m 40s
✔️ packit-tests-pip-deps SUCCESS in 23m 29s
✔️ packit-tests-git-main SUCCESS in 25m 52s
✔️ packit-tests-pip-deps-sess-rec SUCCESS in 2m 56s
✔️ packit-tests-git-main-sess-rec SUCCESS in 3m 11s
✔️ reverse-dep-packit-service-tests SUCCESS in 3m 58s

@lbarcziova
Copy link
Member Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/36b2933466a54f52a2d559c56d8b72c0

✔️ pre-commit SUCCESS in 1m 48s
✔️ packit-tests-rpm SUCCESS in 23m 18s
✔️ packit-tests-pip-deps SUCCESS in 23m 42s
✔️ packit-tests-git-main SUCCESS in 21m 35s
✔️ packit-tests-pip-deps-sess-rec SUCCESS in 2m 47s
✔️ packit-tests-git-main-sess-rec SUCCESS in 3m 03s
✔️ reverse-dep-packit-service-tests SUCCESS in 3m 58s

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label Jan 23, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/a4ab343a658c4e0b9e61baaf112f054b

✔️ pre-commit SUCCESS in 1m 50s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2e76f71 into packit:main Jan 23, 2024
19 checks passed
@lbarcziova lbarcziova deleted the sync-acl-optional branch January 23, 2024 15:13
lbarcziova added a commit to lbarcziova/packit-service that referenced this pull request Jan 23, 2024
@lbarcziova
Pass sync_acls=True to sync_release
61f3f69 
Followup of packit/packit#2214
@lbarcziova lbarcziova mentioned this pull request Jan 23, 2024
Merged
lbarcziova added a commit to lbarcziova/packit-service that referenced this pull request Jan 25, 2024
@lbarcziova
Pass sync_acls=True to sync_release
efeed0f 
Followup of packit/packit#2214
softwarefactory-project-zuul bot added a commit to packit/packit-service that referenced this pull request Jan 25, 2024
@softwarefactory-project-zuul
Pass sync_acls=True to sync_release (#2317)
0bbfd66 
Pass sync_acls=True to sync_release

Followup of packit/packit#2214

RELEASE NOTES BEGIN
N/A
RELEASE NOTES END

Reviewed-by: Nikola Forró
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nforro nforro nforro approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't sync ACLs by default in sync_release
2 participants
@lbarcziova @nforro