Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Kafka Schema Registry compliant JSON #114

Merged
merged 2 commits into from Mar 2, 2022

Conversation

muirandy
Copy link
Contributor

docs: Add recipe for Kafka Schema Registry compliant JSON

docs: Add recipe for Kafka Schema Registry compliant JSON
Copy link
Member

@YOU54F YOU54F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great buddy, couple of minor points, bar the typo should be good to go

Have you got an associated repo with your sample code? Always good to link from a blog post to some code on your repo, to get eyes on your code/GH profile 👍🏾

@muirandy
Copy link
Contributor Author

muirandy commented Mar 2, 2022

FYI, the code sits here:
https://github.com/muirandy/pact-kafka-schema-registry-demo

@muirandy muirandy closed this Mar 2, 2022
@muirandy
Copy link
Contributor Author

muirandy commented Mar 2, 2022

Agh. Didn't mean to close the PR...

@muirandy muirandy reopened this Mar 2, 2022
Copy link
Member

@YOU54F YOU54F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes Andy, looks great. I don’t have write access yet but will get @mefellows or one of the team to give it a merge.

look forward to seeing and sharing your blog post ✌🏽

@YOU54F
Copy link
Member

YOU54F commented Mar 2, 2022

FYI, the code sits here:
https://github.com/muirandy/pact-kafka-schema-registry-demo

I’d link the repo in your blog post for sure, I always enjoyed reading blog posts and then taking a look at the code.

@uglyog uglyog merged commit 7ce75c0 into pact-foundation:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants