Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: pact nirvana refresh for branchs/envs #275

Merged
merged 17 commits into from
Jul 24, 2023

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Jul 20, 2023

Slightly simpler version of #189

I've updated the images in step 4, to use mermaid-js as I don't have the original source, and its got PactFlow graphics in it anyway, so might as well change it up for something that is really easy/open accessible to update in the future

I need to update the images on the others slides as well :)

I've tried to provide some clarification on the PactFlow broker to show that it is

  1. Commercial
  2. Not open source
  3. For the purposes of the guide, it supports either Broker type, and one can revert back to a self hosted Open Source Pact Broker once complete. This may offer less friction for those trying to get buy in, within an organisation.

The PactFlow clarifications are not necessarily meant to be part of this PR, and not the final wording (and not agreed with anyone!)

Updated pages start from

https://deploy-preview-275--docs-pact-io.netlify.app/pact_nirvana/step_3

Updated diagrams

Screenshot 2023-07-20 at 18 25 10 Screenshot 2023-07-20 at 18 25 30 Screenshot 2023-07-20 at 18 25 59

Copy link
Member

@mefellows mefellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to have a crack at updating the remaining mermaid diagrams, merging the text with some changes and getting this out!

website/docs/pact_nirvana/step_3.md Outdated Show resolved Hide resolved
website/docs/pact_nirvana/step_3.md Outdated Show resolved Hide resolved
website/docs/pact_nirvana/step_3.md Outdated Show resolved Hide resolved
website/docs/pact_nirvana/step_4.md Outdated Show resolved Hide resolved
website/docs/pact_nirvana/step_4.md Outdated Show resolved Hide resolved
website/docs/pact_nirvana/step_6.md Show resolved Hide resolved
website/docs/pact_nirvana/step_6.md Show resolved Hide resolved
website/docs/pact_nirvana/step_7.md Outdated Show resolved Hide resolved
website/docs/pact_nirvana/step_7.md Outdated Show resolved Hide resolved
website/docs/pact_nirvana/step_7.md Outdated Show resolved Hide resolved
@mefellows
Copy link
Member

Oh, also, should we get this baby up somewhere: https://github.com/YOU54F/path-to-pact-nirvana?

@mefellows mefellows marked this pull request as ready for review July 24, 2023 05:03
@mefellows mefellows merged commit 00b4380 into master Jul 24, 2023
6 of 7 checks passed
@mefellows mefellows deleted the pact_nirvana_branches_envs branch July 24, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants