New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cors flag in PactOptions #187
Comments
I'm wondering if it makes sense to have |
It makes sense to me @benquinteros, but i'll let Tim/Yousaf comment as they are the maintainers of this repo. |
agree with @mefellows, it is better to reference the interface from pact-js directly. Happy for a PR proposal 👍 otherwise I look to address in the next couple of days |
I remembered why we had a new type - it's because we add I've fixed this in #188 , which
I wanted to hold off merging for a bit of discussion - simple questions, but worth thinking about before we release a version 1:
It's worth keeping in mind that currently this is really also |
I forgot to close this issue before - this is fixed in 0.5.3. It's technically a breaking change if you've explicitly used the type Since this is getting more traction, we'll release a version 1.0.0 soon, which will let us be clearer about breaking changes. |
Are we able to add the cors flag like so, would save having to manually mock a cors interaction.
The text was updated successfully, but these errors were encountered: