fix(options): remove PactOptions redefinition, introduce JestPactOptions #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YOU54F
approved these changes
May 4, 2020
|
I think because we're below version 1, standard won't bump the major version when we make breaking changes. But I also think we should move to version 1 soon. |
TimothyJones
force-pushed
the
fix/dont-redefine-pactoptions
branch
from
68c046d
to
a9e8b3a
Compare
BREAKING CHANGE To avoid needing to modify PactOptions every time it changes, we now union it with the extra options in a type called JestPactOptions
TimothyJones
force-pushed
the
fix/dont-redefine-pactoptions
branch
from
a9e8b3a
to
5152b31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
To avoid needing to modify PactOptions every time it changes, we now union it with the extra options in a type called JestPactOptions