Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass options to the Verifier in the constructor #7

Closed
TimothyJones opened this issue Mar 24, 2021 · 2 comments
Closed

Pass options to the Verifier in the constructor #7

TimothyJones opened this issue Mar 24, 2021 · 2 comments
Labels
enhancement Indicates new feature requests

Comments

@TimothyJones
Copy link
Contributor

At the moment, nestjs-pact passes options to the verifier in the verify call. This is scheduled to be removed in version 10, and is resulting in a warning in the examples see here.

Is it possible to modify the nestjs-pact to pass the options to the verifier using the constructor?
@omermorad
Copy link
Collaborator

Hi @TimothyJones,

I'm pretty sure it is, but let me verify it and get back to you soon

@TimothyJones TimothyJones mentioned this issue Jul 20, 2021
Merged
@TimothyJones TimothyJones mentioned this issue Jan 16, 2022
Closed
3 tasks
@omermorad omermorad added the enhancement Indicates new feature requests label Jan 28, 2022
@TimothyJones TimothyJones mentioned this issue Dec 12, 2022
Merged
7 tasks
lennartquerter added a commit to lennartquerter/nestjs-pact that referenced this issue Dec 21, 2022
@lennartquerter
Merge pull request #2 from TimothyJones/feature/upgrade-pact-10
a1d05b1 
fix!: Removed the injected verifier, getVerifier and the PactVerifierProvider have both been removed. Fixes pact-foundation#7
@YOU54F YOU54F closed this as completed in 84808c5 Jan 17, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TimothyJones @omermorad