Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to specify Pact CLI path in Go package manager #337

Closed
galaxy79 opened this issue Sep 14, 2023 · 7 comments
Closed

How to specify Pact CLI path in Go package manager #337

galaxy79 opened this issue Sep 14, 2023 · 7 comments
Labels
enhancement Indicates new feature requests good first issue Indicates a good issue for first-time contributors help wanted Indicates that a maintainer wants help on an issue or pull request

Comments

@galaxy79
Copy link

Our CI server dont have the PACT CLI installed and the teams using the pact-go is seeing error when running the contract tests in CI server. Is there a way for teams to have the cli in their repo and mention it go package manager, so that go pact sdk can use that cli for the contract tests ? I do see similar capability exist on the node and pact node version (9) allows us to test using it

@mefellows
Copy link
Member

It currently doesn't but I'd support a PR that allowed an environment variable to specify the path.

Come to think of it, you could also just set PATH in your build to include the folder in your project (simpler).

@r-best
Copy link

r-best commented Sep 19, 2023

Hi Matt, I've been working on this with Govind, I got a simple test working with the change you suggested and I should be able to get a PR open for it in the next couple days. 👍
(I tried a couple ways of just changing our PATH too but there were complications in our CI server with that)

@mefellows
Copy link
Member

No worries, thanks!

@mefellows mefellows added help wanted Indicates that a maintainer wants help on an issue or pull request good first issue Indicates a good issue for first-time contributors enhancement Indicates new feature requests labels Sep 20, 2023
@r-best
Copy link

r-best commented Apr 22, 2024

@mefellows Hey Matt, a couple questions about this issue
Sorry for the delay on it, my team put contract testing on the backburner for a while for other work
I had a working fix back then to add a way to specify the CLI path, but it's for v1
I see v2 doesn't really use the CLI anymore, it uses CGo bindings with a pact library instead

Are you still accepting contributions to v1? Due to other issues with our CI server we're having issues with v2, but the update I made for v1 is working fine for us

@r-best
Copy link

r-best commented Apr 22, 2024

Ah, I see there's a v1.x.x branch, could I open a PR with my change to that?

@mefellows
Copy link
Member

Yep, I'm happy to accept a PR to that branch.

@YOU54F
Copy link
Member

YOU54F commented Jun 10, 2024

completed and released #357 (comment)

thanks for the contribution team!

@YOU54F YOU54F closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests good first issue Indicates a good issue for first-time contributors help wanted Indicates that a maintainer wants help on an issue or pull request
Projects
Status: Closed
Development

No branches or pull requests

4 participants