API refactor wip #188
Closed
API refactor wip #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip initial take on unifying http pact API for v2/v3
|
Thanks David, I'm going to create a conversation about this. Might be a better place (not a lot of code here, so we can just refer back to it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in pact slack, a work-in-progress take on unifying http pact API for v2/v3 under
NewPact.Putting it up for feedback at this point. Also a couple
TODOnotes about a behaviour I noticed and a question around how to handle a given state with params in a v2 pact. (A result of not splitting the versions)