fix(golangci-lint): fix errors as raised by linter

[boreyuk]

Linked to #320

[YOU54F]

thanks @boreyuk appreciate the contribution and response on the issue. I've tagged Matt and let the PR run.

I've also updated the release pipeline to 1.20 so this linter probably wants to run against that as well. (I think we can probably drop 1.17/1.18 as they are unsupported for go, but that probably warrants another PR)

[boreyuk]

Oops, seems like the CI fails in the 1.19.x env 😅
The error is as follows:

2023-07-19T14:53:27.3368205Z signal 17 received but handler not on signal stack
2023-07-19T14:53:27.3368767Z fatal error: non-Go code set up signal handler without SA_ONSTACK flag
...
2023-07-19T14:53:27.3464264Z FAIL	github.com/pact-foundation/pact-go/v2/examples/protobuf-message	0.508s
2023-07-19T14:53:27.3464771Z ?   	github.com/pact-foundation/pact-go/v2/examples/types	[no test files]
2023-07-19T14:53:27.3465044Z FAIL

I'm trying to check if this is related to some code I modified 😅

[mefellows]

2023-07-19T14:53:27.3368767Z fatal error: non-Go code set up signal handler without SA_ONSTACK flag

This relates to #269, I think. We have yet to chase down that nasty bug.

[mefellows]

This is great, thank you. I think for the test files and the unused functions, I'll take those as is. For the real ones where we swallow the errors, perhaps we actually need to panic (dramatic, but there is no other pathway in many of them) or at the very least, log an ERROR level statement. Thoughts based on the contexts?

[boreyuk]

I agree - i think that it's better to explicitely panic than silently fail 😛
I will add another commit with the ERROR logs and the panics for unrecoverable errors.

[YOU54F]

thanks for updated commit @boreyuk have kicked off the workflow now

[boreyuk]

Thanks @YOU54F !

After checking, the tests are currently failing due to the panic() added when checking for errors in func (i *V4InteractionWithPluginResponseBuilder) PluginContents(contentType string, contents string) *V4InteractionWithPluginResponseBuilder.
The error, which was ignored before, now causes a panic 😅
The detailed error is: Failed to call out to plugin - Request to configure interaction failed: Config item with key 'pact:proto' and path to the proto file is required

Do you prefer to keep the panic and modify the test, or should I remove the panic() to keep the same behavior than before?

[YOU54F]

So that is a plugin specific error (the plugins themselves define the content make up of their messages, and can choose to error)

I think that error will be coming from the underlying plugin we are calling.

As we can't proceed in that case, and we need to perform the action in the message provided, it would make sense for this to be an error for the user.

the plugins communicate with the central pact framework via grpc so there is room for error here for a number of variables.

Having this swallowed here I think would be disadvantageous all round, so given that I would suggest a panic (provided it that also give us that detail)

Thanks for having a look again my friend, really do appreciate it

[boreyuk]

Thanks for your feedback ! I just modified the test in order to make it pass, and I commited before seeing your comment 😅
I can add another test to check if we "correctly panic" if we have an error on the plugin - anyway, the workflows should pass now 😄

[YOU54F]

No worries @boreyuk I'll let @mefellows make the final call, as he is the core maintainer of the repo.

[YOU54F]

I think we should drop 1.17 due it being out of support

https://endoflife.date/go

is there value is testing across the different supported versions of go with golanglint-ci or just the latest version we use to build/release

[coveralls]

coverage: 37.197% (-0.1%) from 37.338% when pulling 520e776 on boreyuk:golangci-lint-fixes into 7d9ed69 on pact-foundation:master.

[YOU54F]

I think we need to skip linting of the C directive in internal/native/lib.go or maybe there is an option to allow it.

either way it works, once built so I assume this is a bit of a red herring?

[boreyuk]

I think we need to skip linting of the C directive in internal/native/lib.go or maybe there is an option to allow it.

either way it works, once built so I assume this is a bit of a red herring?

I added a commit which modifies the golangci-lint in order to ignore the internal/native/lib.go. I'm not familiar with configuring golangci-lint through Github Actions, so I hope this will work!

[YOU54F]

I'm not familiar with configuring golangci-lint through Github Actions, so I hope this will work!

😄 s'all good, nothing like a bit of experimentation 👍🏾

[YOU54F]

Awesome!

Man it will be nice to be able to see green in the pipeline again. Thanks dude

[mefellows]

This is great, thanks.

Those additional TODOs are also good food for thought, but we can pick them up in the future.

[boreyuk]

Nice ! Thanks to you two 🎉

[mefellows]

You're so welcome, we really appreciate it. If you're up for me, I'd love to chat with you (just hit me up in the #pact-go channel in slack.pact.io).