fix(verifier): acquire HTTP port atomically #344
Conversation
Acquire the port in VerifyMessageProvider and VerifyProvider atomically by using the listener used for a free port acquisition for the HTTP server. This prevents a race condition when multiple pact verifiers run in parallel and compete for free ports, which could result in errors like ``` Expected server to start < 10s. Timed out waiting for http verification proxy on port 34425 - check for errors ```
|
Hi @mefellows, long time no chatting! I wonder if you would entertain this change for v1.x.x? We aren't on 2.x.x yet for a variety of reasons. We bumped into this issue when migrating our CI to a different provider. Prior to the move we experienced the error due to a port acquisition failure in pact provider verification only occasionally and rebuilding usually solved the problem. With the new builders we can't pass any builds anymore. I hope the fix makes sense and I appreciate you considering it. Thanks, |
|
Hey I don't any reason why we can't support this on the v1.x.x branch Have you been able to test the changes in your own project (against your fork) to ensure its performing as you expect? |
|
Thanks Alex, we can bring this in and release as needed - also, nice to hear from you again :) |
|
The release seems to have worked, but perhaps we have a flakey build on the |
|
@YOU54F, @mefellows: yes, we are successfully running off our fork. Now, since it's merged into the upstream we'll point to the HEAD of the upstream v1.x.x instead. Thank you so much for the review! |
Acquire the port in VerifyMessageProvider and VerifyProvider atomically by using the same listener for starting the HTTP server that was used for a free port acquisition.
This prevents a race condition when multiple pact verifiers run in parallel and compete for free ports, which could result in errors like