New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/arm64 binaries #1
Conversation
What should the version be when we release?
can we do stuff like They show
where
Notes on that versioning style (same in pact-broker-docker) |
It's an interesting idea. We'll probably want to version it independently of the CLI version (e.g. if the wrapper API or release has a bug in it). We can't (or rather, shouldn't) use the So perhaps something like This way, the metadata shows what version is contained in the package, but isn't included in the precedence calculations. |
My 2c - yes, it’s definitely build metadata, so it should go after the + (if at all). Secondly- what problem are you solving by having the version in the version number? Most users will want the latest (no matter what) and users who care will be able to read the release notes |
we mention in several places to pin the version of the cli tools used in CI, so you get consistent behaviour. we updated the pact-ruby-standalone script to reflect this, and its mentioned in the pact-go readme.
We've also stated in several issues that its not advisable to use latest and instead pin to a specific version. If I am pinning to a specific version of the pact cli tools via the install scripts in pact-ruby-standalone, the pact cli docker, it might make sense to have that meta easily available to users consuming it via npm so an organisation can get consistent behaviour across the multiple pact-cli tooling entry points You can tag packages in npm so maybe we could just do it that way. so there is always a tag pointing to the bundled version of the pact-ruby-standalone tools. That is my basic rationale, our best practice advice of pinned versions for consistent results. Outside of that, it was just a thought for consistency based on Beth's versioning changes performed in pact-broker-docker, the rationale behind that is below |
Will merge now and we can determine version number shortly and get an initial release out. |
includes pact-ruby-standalone 2.x with arm64 macos/linux binaries.
32 bit windows binaries are no longer downloaded, and
ia32
has been dropped from the package.cpucpus
field.node engines is increased to 16.x
GitHub Actions updated to test on 16, 18, 20 versions of node
Cirrus-CI added to test arm64 macos / linux