Skip to content

Commit

Permalink
Merge pull request #139 from rashiagarwal/fetching-version-specific-p…
Browse files Browse the repository at this point in the history
…acts

feat(verify): add pact-broker-base-url and consumer-version-tag
  • Loading branch information
mefellows committed Feb 9, 2019
2 parents a7ff19b + 1352292 commit de8dba4
Show file tree
Hide file tree
Showing 2 changed files with 52 additions and 0 deletions.
38 changes: 38 additions & 0 deletions src/verifier.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -180,4 +180,42 @@ describe("Verifier Spec", () => {
} as any)).to.not.throw(Error);
});
});

context("when pactBrokerBaseUrl is not provided", () => {
it("should not fail", () => {
expect(() => verifierFactory({
providerBaseUrl: "http://localhost",
pactUrls: [path.dirname(currentDir)]
})).to.not.throw(Error);
});
});

context("when pactBrokerBaseUrl is provided", () => {
it("should not fail", () => {
expect(() => verifierFactory({
providerBaseUrl: "http://localhost",
pactUrls: [path.dirname(currentDir)],
pactBrokerBaseUrl: "http://localhost"
})).to.not.throw(Error);
});
});

context("when consumerVersionTag is not provided", () => {
it("should not fail", () => {
expect(() => verifierFactory({
providerBaseUrl: "http://localhost",
pactUrls: [path.dirname(currentDir)]
})).to.not.throw(Error);
});
});

context("when consumerVersionTag is provided", () => {
it("should not fail", () => {
expect(() => verifierFactory({
providerBaseUrl: "http://localhost",
pactUrls: [path.dirname(currentDir)],
consumerVersionTag: "tag-1"
})).to.not.throw(Error);
});
});
});
14 changes: 14 additions & 0 deletions src/verifier.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@ export class Verifier {
private readonly __argMapping = {
"pactUrls": DEFAULT_ARG,
"providerBaseUrl": "--provider-base-url",
"pactBrokerBaseUrl": "--pact-broker-base-url",
"providerStatesSetupUrl": "--provider-states-setup-url",
"pactBrokerUsername": "--broker-username",
"pactBrokerPassword": "--broker-password",
"consumerVersionTag": "--consumer-version-tag",
"publishVerificationResult": "--publish-verification-results",
"providerVersion": "--provider-app-version",
"customProviderHeaders": "--custom-provider-header",
Expand All @@ -34,6 +36,8 @@ export class Verifier {
constructor(options: VerifierOptions) {
options = options || {};
options.pactBrokerUrl = options.pactBrokerUrl || "";
options.pactBrokerBaseUrl = options.pactBrokerBaseUrl || "";
options.consumerVersionTag = options.consumerVersionTag || "";
options.tags = options.tags || [];
options.pactUrls = options.pactUrls || [];
options.provider = options.provider || "";
Expand Down Expand Up @@ -84,6 +88,14 @@ export class Verifier {
checkTypes.assert.string(options.pactBrokerPassword);
}

if (options.pactBrokerBaseUrl) {
checkTypes.assert.string(options.pactBrokerBaseUrl);
}

if (options.consumerVersionTag) {
checkTypes.assert.string(options.consumerVersionTag);
}

if (options.pactUrls) {
checkTypes.assert.array.of.string(options.pactUrls);
}
Expand Down Expand Up @@ -174,9 +186,11 @@ export interface VerifierOptions extends SpawnArguments {
providerBaseUrl: string;
provider?: string;
pactUrls?: string[];
pactBrokerBaseUrl?: string;
providerStatesSetupUrl?: string;
pactBrokerUsername?: string;
pactBrokerPassword?: string;
consumerVersionTag?: string;
customProviderHeaders?: string[];
publishVerificationResult?: boolean;
providerVersion?: string;
Expand Down

0 comments on commit de8dba4

Please sign in to comment.