fix(verifier): Allow to use progress formatter during verification #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks - looks like the build failed at https://travis-ci.org/pact-foundation/pact-node/jobs/595583946#L121. Another reference to the rspec formatter in tests somewhere. I'm ok with the change. It is also a breaking change, so would you mind please adding the text "BREAKING CHANGE" to the bottom of your commit message so that when we run our deployment process it automatically bumps the major version? |
|
I pushed a commit fixing the build failure - unless I'm missing something, I don't think this is a breaking change, @mefellows? |
mefellows
reviewed
Oct 10, 2019
| @@ -216,6 +217,6 @@ export interface VerifierOptions { | |||
| timeout?: number; | |||
| tags?: string[]; | |||
| monkeypatch?: string; | |||
| format?: 'json' | 'RspecJunitFormatter'; | |||
There was a problem hiding this comment.
@TimothyJones may bad. I thought this was breaking as it was replaced by xml. It looks OK now, so maybe I'm going crazy.
|
Merging - no breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188