Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove arch for Linux standalone binaries #407

Closed
wants to merge 1 commit into from

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Sep 18, 2022

Currently when running on a platform that has no standalone Ruby binaries available everything using pact errors out:

(partly redacted)
    Error while locating pact binary: Cannot find binary for platform 'linux' with architecture 'arm64'.

    > 1 | import { Matchers, Pact } from "@pact-foundation/pact";
        | ^

      at throwError (node_modules/@pact-foundation/pact-core/standalone/install.ts:7:9)
      at Object.getBinaryEntry (node_modules/@pact-foundation/pact-core/standalone/install.ts:51:9)
      at Object.standalone (node_modules/@pact-foundation/pact-core/src/pact-standalone.ts:40:5)
      at Object.<anonymous> (node_modules/@pact-foundation/pact-core/src/pact-standalone.ts:72:16)
      at Object.<anonymous> (node_modules/@pact-foundation/pact-core/src/server.ts:2:1)
      at Object.<anonymous> (node_modules/@pact-foundation/pact-core/src/pact.ts:2:1)
      at Object.<anonymous> (node_modules/@pact-foundation/pact-core/src/index.ts:1:1)
      at Object.<anonymous> (node_modules/@pact-foundation/src/httpPact/index.ts:2:1)
      at Object.<anonymous> (node_modules/@pact-foundation/src/index.ts:25:1)

I'm using the submitted diff with patch-package and it's working fine, but it not the right fix. However, there's no "correct" handling available for any OS/arch combinations not supported by Traveling Ruby currently, so I'm submitting this anyway. :)

@mefellows
Copy link
Member

Ah, interesting thanks for this.

I really wish I'd removed the other classes in the latest release because most people aren't using them (assumption) and we don't want them to (not assumption). This is definitely a case for moving the the new native core into Pact JS because boundaries, and then leaving this package to just wrap the Ruby, but that won't solve the problem completely because having the Ruby binaries can be useful for many.

I'll have to have a think about a nice way to do this. We obviously don't want this error, but we don't want to just squash the error for those who might think it worked because it installed correctly.

@YOU54F
Copy link
Member

YOU54F commented May 18, 2023

Superseded by #445

@YOU54F YOU54F closed this May 18, 2023
@mefellows
Copy link
Member

#445 is now released 🎉 !

@mmoll mmoll deleted the linux_arch branch July 6, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants