Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: use @pact-foundation scope for pact dependency for consistency #116

Closed
mboudreau opened this issue Oct 15, 2017 · 3 comments
Closed

Proposal: use @pact-foundation scope for pact dependency for consistency #116

mboudreau opened this issue Oct 15, 2017 · 3 comments
Assignees
@mboudreau
Projects
Pact JS Roadmap

Comments

@mboudreau
Copy link
Contributor

All other pact-foundation packages are using this scoping, which can also prevent people from confusing the real pact libraries vs fake ones or malicious ones, which has been shown to be attached to certain popular packages, but with a mispelling.
@mboudreau mboudreau added this to TODO in Pact JS Roadmap Oct 15, 2017
@mboudreau mboudreau self-assigned this Oct 15, 2017
@mefellows
Copy link
Member

Let's do this when we cut over to TS.

@mefellows
Copy link
Member

We should also take into consideration #64 as this may have unintended consequences. The work you've done removing optional dependencies is probably going to mitigate this though, thankfully.

@mefellows mefellows mentioned this issue Dec 5, 2017
Closed
31 tasks
@mefellows
Copy link
Member

See https://www.npmjs.com/package/@pact-foundation/pact - done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mboudreau mboudreau

Labels
None yet
Projects
Pact JS Roadmap
TODO
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mefellows @mboudreau