Message-consumer ignores the metadata given to withMetadata

[dimkin-eu]

Checklist

Before making a feature request, I have:

• Searched the issues to check that this feature hasn't been requested before
• Checked the documentation to see if it is possible to do what I want already

Feature description

in message consumer example only body is verified now, could be nice to do the same also with metadata
To be more specific - dog handler must verify also metadata from spec

Use case

as this info is in the pact and could be verified by providers, could be nice, that it is done also on the js consumer side.

[TimothyJones]

I’m sorry, I don’t understand what you’re asking for. Could you elaborate a bit?

…

Sent from my mobile

On 11 Jun 2021, at 4:18 pm, Dmitry Munda ***@***.***> wrote:  Checklist Before making a feature request, I have: Searched the issues to check that this feature hasn't been requested before Checked the documentation to see if it is possible to do what I want already Feature description in message consumer example only body is verified now, could be nice to do the same also with metadata To be more specific - dog handler must verify also metadata from spec Use case as this info is in the pact and could be verified by providers, could be nice, that it is done also on the js consumer side. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[dimkin-eu]

@TimothyJones , no worries. dogApiHandler verifies only withContent part, but withMetadata is not (it's not even passed to handler)

[TimothyJones]

@mefellows : Do you know what the metadata field is for? It's not used anywhere in the source as far as I can see (except for where it's set).

[mefellows]

The metadata is not actually used on the consumer side, or at least, it's not currently exposed to it. It may be used on the provider side, to verify things like message headers.

Classic example would be the queue or topic it's published on.

Pact JS does not currently have the ability to validate message metadata, only Pact JVM does at the present time.

[TimothyJones]

Ah, right. It seems that Pact JS currently allows you to specify the metadata in the consumer, but it's not written to the pact (as far as I can see, it's not even passed beyond the DSL layer).

[TimothyJones]

@dimkin-eu What do you think of something like this on the provider side:

  messageProviders: {
    'a request to save an event': providerWithMetadata(
      () => yourUsualProviderHere(),
      { // Arbitrary metadata here
        'content-type': 'application/json',
        messageQueueType: 'AWS-SQS',
      }
    ),
  },

?

[TimothyJones]

This is fixed in 10.0.0-beta.45, and will be released in the next major release.