New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it clear that scripts in package.json can be used for publish and can-i-deploy (etc) #711
Comments
Here's an example line using the binstubs directly https://github.com/pact-foundation/pact-js/blob/master/examples/e2e/package.json#L11 We should change (at least) the instructions here: https://github.com/pact-foundation/pact-js#publishing-pacts-to-a-broker |
While we're there we could move all the credentials to environment variables too (since they're hard coded throughout) |
❤️ |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I would like to make the docs more beginner friendly and tackle this issue if possible. this looks like a good place to start. is this still relevant @TimothyJones ? |
Yes, I believe it is still relevant (I am no longer a maintainer)
…Sent from my mobile
On 5 Apr 2022, at 1:18 pm, Daniel Glazer ***@***.***> wrote:
I would like to make the docs more beginner friendly and tackle this issue if possible. this looks like a good place to start. is this still relevant @TimothyJones ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Thanks @danielglazer, that'd be great. I think the examples are all up to date now, it's just the documentation piece. |
This is done, closing! |
At the moment, most of the examples use a
publish.js
for publication. This isn't the most developer-friendly pattern, since it means you're essentially copying boilerplate tooling around each time you use pact.We have binstubs exposed by pact-js-core/pact-node- we should:
The text was updated successfully, but these errors were encountered: