Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear that scripts in package.json can be used for publish and can-i-deploy (etc) #711

Closed
TimothyJones opened this issue Jul 18, 2021 · 8 comments

Comments

@TimothyJones
Copy link
Contributor

At the moment, most of the examples use a publish.js for publication. This isn't the most developer-friendly pattern, since it means you're essentially copying boilerplate tooling around each time you use pact.

We have binstubs exposed by pact-js-core/pact-node- we should:

  1. Update the examples to have package.json scripts that use the binstubs directly
  2. Improve the documentation to make it clear that you can use these binstubs
@TimothyJones
Copy link
Contributor Author

Here's an example line using the binstubs directly https://github.com/pact-foundation/pact-js/blob/master/examples/e2e/package.json#L11

We should change (at least) the instructions here: https://github.com/pact-foundation/pact-js#publishing-pacts-to-a-broker

@TimothyJones
Copy link
Contributor Author

While we're there we could move all the credentials to environment variables too (since they're hard coded throughout)

@bethesque
Copy link
Member

❤️

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@danielglazer
Copy link

I would like to make the docs more beginner friendly and tackle this issue if possible. this looks like a good place to start. is this still relevant @TimothyJones ?

@TimothyJones
Copy link
Contributor Author

TimothyJones commented Apr 5, 2022 via email

@mefellows
Copy link
Member

Thanks @danielglazer, that'd be great. I think the examples are all up to date now, it's just the documentation piece.

@mefellows
Copy link
Member

This is done, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants