includeWipPactsSince cant be undefined

[dimkin-eu]

Software versions

Please provide at least OS and version of pact-js

• Node Version: 16

Issue Checklist

Please confirm the following:

• I have upgraded to the latest
• I have the read the FAQs in the Readme
• I have triple checked, that there are no unhandled promises in my code and have read the section on intermittent test failures
• I have set my log level to debug and attached a log file showing the complete request/response cycle
• For bonus points and virtual high fives, I have created a reproduceable git repository (see below) to illustrate the problem

Expected behaviour

this must work

includeWipPactsSince: isCI ? new Date(Date.now() - 7 * 24 * 60 * 60 * 1000).toISOString().split("T")[0] : undefined,

Actual behaviour

TypeError: includeWipPactsSince

Steps to reproduce

I've just ( tried to ) upgrade from 9.17.3 to 10.1.2 and having TypeError: includeWipPactsSince

Reporting this issue per @mefellows request from slack

[TimothyJones]

Why do you expect that to work? What would includeWipPactsSince: undefined mean?

I don't think this is a bug.

[TimothyJones]

If you want a way to only specify includeWipPactsSince based on a variable, this is more idiomatic:

...(isCI ? { 
       includeWipPactsSince: new Date(Date.now() - 7 * 24 * 60 * 60 * 1000).toISOString().split("T")[0] 
    } : {})

[dimkin-eu]

undefined worked perfectly before upgrade
types.d.ts asks for string includeWipPactsSince?: string;

[TimothyJones]

includeWipPactsSince?: string;

What about this makes you think it can be undefined? This says you may have includeWipPactsSince, and if you do, it must be a string.

This has not changed since 9.x - see the old definition here.

See the discussion in slack for more information. I suspect the break is actually in your typescript options.

[mefellows]

Closing as won't fix.