Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatchersV3.string() with no arguments doesn't match strings #945

Closed
3 of 5 tasks
TimothyJones opened this issue Sep 21, 2022 · 1 comment · Fixed by #946
Closed
3 of 5 tasks

MatchersV3.string() with no arguments doesn't match strings #945

TimothyJones opened this issue Sep 21, 2022 · 1 comment · Fixed by #946
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@TimothyJones
Copy link
Contributor

Software versions

  • Consumer Pact library: 10.1.3

Issue Checklist

Please confirm the following:

  • I have upgraded to the latest
  • I have the read the FAQs in the Readme
  • I have triple checked, that there are no unhandled promises in my code and have read the section on intermittent test failures
  • I have set my log level to debug and attached a log file showing the complete request/response cycle
  • For bonus points and virtual high fives, I have created a reproduceable git repository (see below) to illustrate the problem

Expected behaviour

MatchersV3.string() should match any string

Actual behaviour

this line has no default argument, so MatchersV3.string() actually produces { 'pact:matcher:type': 'type', value: undefined } which will not work as expected.

Steps to reproduce

Make a pact expectation that includes MatchersV3.string()

Relevant log files

N/A

@TimothyJones TimothyJones added the bug Indicates an unexpected problem or unintended behavior label Sep 21, 2022
@TimothyJones
Copy link
Contributor Author

This is kind of a breaking change, since the V2 matcher does have a default argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
1 participant